fix: lint under GOOS=windows, bound junction path length#51
Merged
Conversation
…ion path length `make check`/`make fix` only linted the host GOOS, so linkdir_windows.go was silently skipped in CI on Linux. Running golangci-lint under both linux and windows surfaced a real bug: setJunction built the reparse-point buffer from an unbounded target path, which can overflow the uint16 length fields and the kernel's MAXIMUM_REPARSE_DATA_BUFFER_SIZE cap. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make check/make fixnow lint under bothGOOS=linuxandGOOS=windows, so build-tagged files likelinkdir_windows.gostop being silently skipped on Linux CI/dev machinessetJunctionbuilt the reparse-point buffer from an unbounded target path, which can overflow the uint16 length fields and the kernel'sMAXIMUM_REPARSE_DATA_BUFFER_SIZEcap — now bounds-checked with a clear error0o755(was0o777) and adds a test coveringparseSemver's malformed-tag rejection rulesTest plan
make check(lint under linux + windows) andmake testpass